drivaspreset commented on code in PR #43004:
URL: https://github.com/apache/superset/pull/43004#discussion_r4047834215
##########
superset-frontend/playwright.config.ts:
##########
@@ -119,6 +124,8 @@ export default defineConfig({
// via API with unique names — no shared mutable state between tests.
name: 'chromium-sqllab',
testMatch: '**/tests/sqllab/**/*.spec.ts',
+ // See the chromium-gaq project below.
+ testIgnore: '**/global-async-query*.spec.ts',
Review Comment:
Good catch on the contradiction, though it resolves the other way round: the
testIgnore is intentional and the comment was wrong.
That spec needs GLOBAL_ASYNC_QUERIES enabled, which only the workflow's GAQ
step provides — playwright-run-gaq explicitly runs
sqllab/global-async-query-sqllab.spec.ts alongside the two dashboard specs.
Without the exclusion it would also be collected by the ordinary SQL Lab run,
where the flag is off, and skip itself on every execution — reporting coverage
it never had. Reconciling the ignore pattern instead would have dropped it from
CI entirely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
