aminghadersohi commented on code in PR #44370:
URL: https://github.com/apache/superset/pull/44370#discussion_r4055035618
##########
superset-frontend/src/components/Chart/ChartRenderer.test.tsx:
##########
@@ -483,3 +500,32 @@ test('does not render chart during loading when last data
has errors', () => {
const { queryByTestId } = render(<ChartRenderer {...props} />);
expect(queryByTestId('mock-super-chart')).not.toBeInTheDocument();
});
+
+test('chart mask updates preserve incoming selection provenance', () => {
+ const updateDataMask = jest.fn();
+ render(
+ <ChartRenderer
+ {...requiredProps}
+ latestQueryFormData={{
+ datasource: '7__semantic_view',
+ viz_type: 'table',
+ semantic_selection_version: 'cube-member-id-v1',
Review Comment:
`latestQueryFormData` omits `semantic_selection_sources`, so the
`...(sourceForm.semantic_selection_sources ?? [])` clause at
ChartRenderer.tsx:394 is unpinned — deleting it leaves 543 tests green. Adding
the field here plus the matching expected entry reds it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
