codeant-ai-for-open-source[bot] commented on code in PR #44370:
URL: https://github.com/apache/superset/pull/44370#discussion_r4054405330
##########
superset-frontend/packages/superset-ui-core/src/query/extractExtras.ts:
##########
@@ -72,6 +73,27 @@ export default function extractExtras(formData:
QueryFormData): ExtractedExtra {
}
});
+ const selectionSources = [
+ ...getSemanticSelectionSources(formData.extra_form_data),
+ ...(formData.semantic_selection_sources ?? []),
+ ];
+ const hasUnversionedExtras = (formData.extra_filters ?? []).some(
+ filter =>
+ !['__time_range', '__time_grain', '__time_compare'].includes(filter.col),
+ );
Review Comment:
✅ **Customized review instruction saved!**
**Instruction:**
> Keep __time_col and __granularity treated as unversioned member
selections; do not classify them with scalar temporal settings such as
__time_range, __time_grain, or __time_compare.
**Applied to:**
- `superset-frontend/packages/superset-ui-core/src/query/extractExtras.ts`
---
💡 *To manage or update this instruction, visit: [CodeAnt AI
Settings](https://app.codeant.ai/org/settings/learnings)*
##########
superset-frontend/src/dataMask/reducer.ts:
##########
@@ -77,6 +77,16 @@ export interface HydrateDataMaskAction {
};
}
+function getRestoredSelectionEvidence(
+ mask: DataMask | undefined,
+ version: string | undefined,
+): Partial<DataMask> {
+ // A restored value must not inherit the default's identity evidence.
+ return version && mask?.filterState && !mask.extraFormData
+ ? { extraFormData: {} }
Review Comment:
✅ **Customized review instruction saved!**
**Instruction:**
> Do not flag replacing default extraFormData when restoring a versioned
filterState without its own extraFormData; this intentionally prevents
inheriting the default selection's identity evidence.
**Applied to:**
- `superset-frontend/src/dataMask/reducer.ts`
---
💡 *To manage or update this instruction, visit: [CodeAnt AI
Settings](https://app.codeant.ai/org/settings/learnings)*
##########
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterValue.tsx:
##########
@@ -203,6 +207,7 @@ const FilterValue: FC<FilterValueProps> = ({
...filter,
datasetId,
datasourceType,
+ semantic_selection_version,
Review Comment:
✅ **Customized review instruction saved!**
**Instruction:**
> Do not flag nested values as missing effect dependencies when they are
derived from an immutable parent object already included in the dependency
list; parent reference changes recompute the derived values.
**Applied to:**
-
`superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterValue.tsx`
---
💡 *To manage or update this instruction, visit: [CodeAnt AI
Settings](https://app.codeant.ai/org/settings/learnings)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
