villebro commented on code in PR #44250: URL: https://github.com/apache/superset/pull/44250#discussion_r4057464934
########## docs/admin_docs/installation/docker-builds.mdx: ########## @@ -46,12 +51,14 @@ Here are the build presets that are exposed through the `supersetbot docker` uti - `dev`: For development, with a headless browser, dev-related utilities and root access. This includes some commonly used database drivers like `mysqlclient`, `psycopg2-binary` and some other used for development/CI -- `py311`, e.g., Py311: Similar to lean but with a different Python version (in this example, 3.11). -- `ci`: For certain CI workloads. -- `websocket`: For Superset clusters supporting advanced features. -- `dockerize`: Used by Helm in initContainers to wait for database dependencies to be available. +- `py311` and `py312`: Similar to lean but with a different Python version. -The `ci` and `showtime` Docker targets share an entrypoint that runs container +Standalone `websocket` and `dockerize` images are not published. The realtime +WebSocket server is bundled in the `superset`, `lean`, and `dev` images and can +be started with `/app/docker/entrypoints/run-websocket.sh`. Helm init containers +use the main Superset image for dependency checks. + +The unpublished `ci` and `showtime` Docker targets share an entrypoint that runs container Review Comment: Valid, and self-inflicted by this PR — it added the word "unpublished" to that paragraph in the same change that documented Showtime publishing `pr-<PR>-<sha>-ci` tags, so the page contradicted itself in two places. Fixed in 5a30e8f995. The paragraph now states what is true of each target rather than lumping them together: neither `ci` nor `showtime` is part of the published preset matrix, `ci` images stay on the CI runner, and `showtime` images are published by Showtime under the `pr-<PR>-<sha>-ci` tags documented further down the page. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
