sha174n commented on PR #43020: URL: https://github.com/apache/superset/pull/43020#issuecomment-5761296429
@rusackas Pushed one test-only commit after your approval (1439bbcdbe), flagging it since it landed post-LGTM. The engine set behind the `sql_validation` capability flag is restated in three places (`superset/config.py`, `SQL_VALIDATION_ENGINES` in `db_engine_specs/lib.py`, and the docs generator) and was kept in sync by comment alone. `tests/unit_tests/db_engine_specs/test_lib.py` now asserts the three agree, so drift fails a test instead of silently publishing a wrong flag and score in the matrix. It reads the config default via `ast` rather than importing `superset.config`, so it checks the shipped default and not an operator's overrides. No production code changed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
