sha174n commented on PR #43020: URL: https://github.com/apache/superset/pull/43020#issuecomment-5763027155
@rusackas Two small test/docs-only commits since your approval, flagging them as they landed post-LGTM. `ca15934a14` merges current master, so the conflicts are clear again and GitHub reports the PR mergeable. `640c90409f` hardens the guard test added in `1439bbcdbe`: it reads the shipped `SQL_VALIDATORS_BY_ENGINE` default out of `config.py` with `ast`, but only matched a plain assignment, so annotating that setting would have read as it being absent rather than as drift. It now accepts an annotated assignment too, the same way the docs generator already walks these sources. Same commit fixes a stale cross-reference in `db_engine_specs/README.md`: the SQL validation note said "the tables below", but the capability tables are above it. No production code changed in either. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
