aminghadersohi commented on PR #44435: URL: https://github.com/apache/superset/pull/44435#issuecomment-5767293657
Good catch, and yes — but in this PR rather than a follow-up, so there's one rule and not a promise. Doing exactly what you suggested: both paths key on `columnType == "BASE_AXIS"` instead of `columns[0]`, so the axis-at-`columns[1]` case stops diverging and the dashboard path stops writing an inert `timeGrain` onto a non-axis column. Adding a regression test for that case, and keeping the axis-at-0 behaviour byte-identical so nothing the frontend builds moves. Pushing on top — no force-push, your approval stays as is. Ping me when it lands if you want another look at the widened diff. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
