aminghadersohi commented on PR #44435: URL: https://github.com/apache/superset/pull/44435#issuecomment-5767372511
Landed in `340c4f4a`. The helper moved to `superset/common/utils/time_grain_utils.py` — neither caller should own it, and that keeps `charts/data` from importing the MCP service. Both paths now call it, so the `columns[0]` write is gone. Axis-at-`columns[1]` test failed 2/2 before, passes after; axis-at-0 output compared byte-for-byte across 336 cases and is unchanged. Your approval is still on the PR and I haven't touched it — the diff is wider than what you signed off on, so take another look if you want one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
