sha174n commented on PR #44494: URL: https://github.com/apache/superset/pull/44494#issuecomment-5768976700
@rusackas both confirmed, and both are moot after the pivot in d6284aa157. `THUMBNAIL_EXECUTORS = [ExecutorType.CURRENT_USER]` (`superset/config.py:1303`) — right, and that is a second reason the editorship gate was wrong. This path now keeps `raise_for_access(chart=...)` and adds only an explicit guest deny, so thumbnail capture by a non-editor viewer behaves exactly as on master. On the missing `.catch()`: also right, `updateQueryContext` is fired from a `useEffect` with no rejection handler (`ExploreChartPanel/index.tsx:232-257`), so a 403 there would surface as an unhandled rejection rather than be swallowed. The original description was wrong to lean on that. The only principal the current version refuses is a guest token, which never reaches Explore, so no new rejection path is introduced. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
