sha174n commented on PR #44494: URL: https://github.com/apache/superset/pull/44494#issuecomment-5780928197
@bito-code-review the backfill log is now split by status in 41858b30f0: a 403 is an expected outcome here (the relaxed path also refuses externally managed charts, so those 403 on every Explore mount) and stays at `debug`, while anything else logs at `warn` per the precedent you cited. Verified the counts: 37 `logging.warn` vs 2 real `logging.debug` in `superset-frontend/src/`. On the mock annotations, leaving those as-is. The prevailing style in `tests/unit_tests/commands/chart/update_test.py` is unannotated `mocker.patch` (~20 call sites vs 4 annotated), so the new mocks match the file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
