rusackas commented on PR #44017: URL: https://github.com/apache/superset/pull/44017#issuecomment-5769580627
Nice catch, @EnxDev, and looks like bito's landed on the same fix. `g` outlives the request inside a shared app context, so the cache doesn't actually have the lifetime the docstring promises, that matters for anything holding an app context across multiple requests (tests with an autouse fixture, some worker setups). Keying it off `flask.request` instead of `g` seems like the right move since it's already gated by the same `has_request_context()` check. Want to see that addressed, plus a test that reuses one app context across two requests, before this merges. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
