no-hup commented on PR #44017: URL: https://github.com/apache/superset/pull/44017#issuecomment-5775311672
Heads-up on the red checks (`babel-extract` and the `check_pot_drift` unit test) — they aren't from this diff. This PR only touches `superset/subjects/utils.py` and its test. The `check_pot_drift` failure lists five strings missing from `messages.pot`: the alert/report retry messages, plus `Screenshot cache is unavailable` and `Screenshot request is temporarily unavailable`. Those live in `superset/reports/notifications/*` and `superset/dashboards/api.py` on master, not in anything here. `messages.pot` on current master doesn't carry them yet, so any branch cut from master fails this check the same way — rebasing won't clear it, it needs a `messages.pot` regeneration on master. Leaving this one as-is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
