rusackas commented on PR #44216: URL: https://github.com/apache/superset/pull/44216#issuecomment-5769644541
Hey @krmmkr, thanks for pushing the review fixes. CI's still red though, pre-commit and lint-frontend are both failing with actual errors this time (lint-frontend found 3 errors, pre-commit's failing on end-of-file, oxfmt, and oxlint), so this isn't mergeable as-is. Also a handful of threads are still open even though you've replied with fixes, in particular the requiredFirst canvas filter deadlock and the validateStatus/Apply gating ones. Once pre-commit's clean, could you ping @sadpandajoe so those can get confirmed and marked resolved? Let me know if you want help with any of it, but I'll take a stab at pre-commit now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
