sadpandajoe commented on code in PR #44216:
URL: https://github.com/apache/superset/pull/44216#discussion_r4106927215


##########
superset-frontend/packages/superset-ui-core/src/utils/featureFlags.ts:
##########
@@ -33,6 +33,7 @@ export enum FeatureFlag {
   ChartPluginsExperimental = 'CHART_PLUGINS_EXPERIMENTAL',
   ConfirmDashboardDiff = 'CONFIRM_DASHBOARD_DIFF',
   CssTemplates = 'CSS_TEMPLATES',
+  DashboardNativeFiltersOnCanvas = 'DASHBOARD_NATIVE_FILTERS_ON_CANVAS',

Review Comment:
   I see we are adding a new feature flag here. Couple of questions here:
   1. why is this behind a feature flag?
   2. what condition need to be met to remove this feature flag or is it a 
permanent feature flag?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to