rusackas commented on PR #44365: URL: https://github.com/apache/superset/pull/44365#issuecomment-5769770955
Sadpandajoe's thread on the FAB rollback issue is the one I'd want cleared before this merges: if add_user/update_user swallow a failure and roll back the shared session, consume()'s pending DELETE gets undone without ever raising, so the token's still redeemable after a failed login. That undercuts the single-use guarantee the whole design leans on. A couple of the other threads from that same round are still open too, worth a look before we call this ready. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
