bito-code-review[bot] commented on code in PR #44457:
URL: https://github.com/apache/superset/pull/44457#discussion_r4074820970
##########
superset-frontend/scripts/po2json.sh:
##########
@@ -30,8 +30,8 @@ do
filename="${file%.*}"
if [ $extension == "po" ]
then
- echo "po2json --domain superset --format jed1.x $file $filename.json"
- po2json --domain superset --format jed1.x --fuzzy $file $filename.json
+ echo "po2json --domain superset --format jedold $file $filename.json"
+ po2json --domain superset --format jedold --fuzzy $file $filename.json
Review Comment:
<!-- Bito Reply -->
The suggestion provided by the reviewer is appropriate to apply. The current
configuration uses a format that is incompatible with the version of the
library used in the project, which causes translation lookups to fail. Updating
the format to the one recommended ensures compatibility with the project's
dependencies.
**superset-frontend/scripts/po2json.sh**
```
echo "po2json --domain superset --format jed $file $filename.json"
po2json --domain superset --format jed --fuzzy $file $filename.json
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
