bito-code-review[bot] commented on code in PR #44154:
URL: https://github.com/apache/superset/pull/44154#discussion_r4085098160
##########
superset-frontend/src/utils/downloadUtils.ts:
##########
@@ -19,29 +19,12 @@
import { FeatureFlag, isFeatureEnabled } from '@superset-ui/core';
import { t } from '@apache-superset/core/translation';
import { logging } from '@apache-superset/core/utils';
-import {
- addInfoToast,
- addWarningToast,
-} from 'src/components/MessageToasts/actions';
+import { addInfoToast } from 'src/components/MessageToasts/actions';
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Unbound info toast never renders</b></div>
<div id="fix">
The added doc comment (lines 127-131) states an unbound action creator 'only
build[s] a Redux action object and never render[s] a toast' — yet line 153
still calls the raw imported `addInfoToast` (kept on this changed import line).
`addToast` in `actions.ts` returns `{type: ADD_TOAST, payload}` without
dispatching, so the 'Preparing N charts for export' info toast never appears.
Bind it like `addWarningToast`.
</div>
</div>
<small><i>Code Review Run #ec5084</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
