bito-code-review[bot] commented on code in PR #44154:
URL: https://github.com/apache/superset/pull/44154#discussion_r4086879804
##########
superset-frontend/src/utils/downloadUtils.ts:
##########
@@ -19,29 +19,12 @@
import { FeatureFlag, isFeatureEnabled } from '@superset-ui/core';
import { t } from '@apache-superset/core/translation';
import { logging } from '@apache-superset/core/utils';
-import {
- addInfoToast,
- addWarningToast,
-} from 'src/components/MessageToasts/actions';
+import { addInfoToast } from 'src/components/MessageToasts/actions';
Review Comment:
<!-- Bito Reply -->
The suggestion to avoid such reviews is not necessary. The review was
accurate and helpful, as it correctly identified that the previous test
assertion was invalid because `toThrow` requires a function, not a promise that
resolves to `undefined`. The user has already acknowledged this and implemented
the correct fix using `resolves.toBeUndefined()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
