sha174n commented on PR #44494: URL: https://github.com/apache/superset/pull/44494#issuecomment-5799947540
@bito-code-review on the mock type annotations (run #ef12da): declining that one. The dominant convention in `tests/unit_tests/commands/chart/update_test.py` is unannotated, `find_by_id`/`raise_for_editorship`/`raise_for_access` are bare assignments at lines 170, 190, 194, 237 and 241, and the new mocks sit in that same cluster. Annotating only the three new lines would make them inconsistent with their immediate neighbours. The two `: Mock` uses at lines 60 and 105 are the outliers, not the rule. The two actionable items from run #b22603 are answered inline and the cleanup is tightened in 590bffbdcf. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
