no-hup commented on PR #43990: URL: https://github.com/apache/superset/pull/43990#issuecomment-5806540174
Good point — you're right that `is_editor`/`is_viewer` each call `get_user_subject_ids`, so the editor and viewer reads stay one query per chart even after the prefetch loads the relationships. I've noted that next to the `can_access_datasource` caveat in the description. The actual fix for it is in #44017: it memoises `get_user_subject_ids` per request, which flattens the editor/viewer paths (and `can_access_datasource`) to a constant number of subject-id lookups. I kept it in a separate PR since it touches the security manager rather than this DAO. Also refreshed this branch on master (e2ab684) to clear the merge conflict. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
