sadpandajoe opened a new pull request, #44629: URL: https://github.com/apache/superset/pull/44629
### SUMMARY Matrixify's metrics-axis grid generation (`generateCellFormData` in `MatrixifyGridGenerator.ts`) only wrote the primary `metrics`/`metric` fields for each grid cell. For a multi-query viz type — currently only Mixed Chart (`mixed_timeseries`), which reads its second query's metric from a `metrics_b` suffixed field — that suffixed field was never updated per cell, so every cell in the grid showed a different primary series but an identical, frozen secondary series. This mirrors the dimension-filter case already handled for multi-query viz types (`appendMatrixifyFilters`, which fans a filter value out to every `adhoc_filters_*` collection). This change adds the equivalent `overrideMatrixifyMetrics`, which sets `metrics`/`metric` plus every `metrics_<suffix>` field found on the cell's form data, and calls it instead of writing the fields directly. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Not included — this environment's local dev stack hits a pre-existing, unrelated alembic multi-head migration error on a fresh master build, so a live screenshot could not be captured. The behavior is covered by the added unit test instead. ### TESTING INSTRUCTIONS - `superset-frontend/packages/superset-ui-core/src/chart/components/Matrixify/MatrixifyGridGenerator.test.ts` adds a test asserting a metrics-axis selection is applied to every query-specific metrics collection (e.g. `metrics_b`), not just the primary `metrics` field. - Manual: enable `MATRIXIFY`, create a Mixed Chart (`mixed_timeseries`), configure a metrics-axis Matrixify grid, and confirm each grid cell's second query series updates per cell instead of staying fixed to the first cell's value. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [x] Required feature flags: MATRIXIFY - [x] Changes UI - [ ] Includes DB Migration - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
