codeant-ai-for-open-source[bot] commented on code in PR #44645:
URL: https://github.com/apache/superset/pull/44645#discussion_r4102644676
##########
superset/utils/rls.py:
##########
@@ -60,6 +60,7 @@ def apply_rls(
schema: str,
parsed_statement: BaseSQLStatement[Any],
exclude_dataset_id: int | None = None,
+ include_global_guest_rls: bool = False,
Review Comment:
**Suggestion:** Standalone SQL Lab and executor statements omit global guest
predicates because their callers use this default, allowing authorized guest
users to query rows outside their token scope.
**Assessment:** ๐ด `Critical` ยท ๐ `Occurrence: Rarely` ยท ๐ท๏ธ `Security`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=d451a07e91bb4da7b08650c64dc39266&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=d451a07e91bb4da7b08650c64dc39266&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/utils/rls.py
**Line:** 63:63
**Comment:**
*Security: Standalone SQL Lab and executor statements omit global guest
predicates because their callers use this default, allowing authorized guest
users to query rows outside their token scope.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44645&comment_hash=8b88ffe3af306216b77297eb737bfcf203c11ceee7c9411bf577901b24a20c99&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44645&comment_hash=8b88ffe3af306216b77297eb737bfcf203c11ceee7c9411bf577901b24a20c99&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
