bito-code-review[bot] commented on PR #44645:
URL: https://github.com/apache/superset/pull/44645#issuecomment-5829285935
<!-- Bito Reply -->
The flagged issue is correct. The PR already implements the proposed fix by
introducing an `include_global_guest_rls` parameter to `apply_rls` and
`get_predicates_for_table`, allowing callers to explicitly include global guest
RLS rules when necessary (e.g., for ad-hoc subqueries).
As the fix is already present in the provided diff, no further
implementation is required. There are no other review comments in the provided
context to address.
**superset/utils/rls.py**
```
include_global_guest_rls: bool = False,
) -> bool:
"""
Modify statement inplace to ensure RLS rules are applied.
:param include_global_guest_rls: Also inject global (unscoped) guest RLS
rules. Leave False for a virtual dataset's inner SQL, whose outer
query
already applies them; pass True when the statement is not constrained
by an outer query that applies them, such as an adhoc sub-query.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
