codeant-ai-for-open-source[bot] commented on code in PR #44652:
URL: https://github.com/apache/superset/pull/44652#discussion_r4104274578
##########
superset/utils/pandas_postprocessing/histogram.py:
##########
@@ -107,9 +106,14 @@ def hist_values(series: Series) -> np.ndarray:
)
histogram_df.columns = bin_edges_str
+ # normalize by the total count of data points before accumulating, so that
a
+ # cumulative histogram shows the share of data points up to each bin
if normalize:
histogram_df = histogram_df / histogram_df.values.sum()
Review Comment:
**Suggestion:** With null group keys, pandas omits those rows from
`histogram_df`, so this denominator excludes data points and grouped normalized
cumulative values incorrectly end at 1.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes` ยท ๐ท๏ธ `Incomplete
implementation`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=1fa39bda9e5645959c8a077dbd656eff&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=1fa39bda9e5645959c8a077dbd656eff&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/utils/pandas_postprocessing/histogram.py
**Line:** 111:112
**Comment:**
*Incomplete Implementation: With null group keys, pandas omits those
rows from `histogram_df`, so this denominator excludes data points and grouped
normalized cumulative values incorrectly end at 1.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44652&comment_hash=f6fb842965d0e640f9a58f40452ae2d533556d34d2e1bf38c0608c29281edfb4&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44652&comment_hash=f6fb842965d0e640f9a58f40452ae2d533556d34d2e1bf38c0608c29281edfb4&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
