rusackas commented on PR #44652: URL: https://github.com/apache/superset/pull/44652#issuecomment-5883760911
Thanks for tracking this down, @SulimanAbdulrazzaq, the before/after numbers make it easy to see what was wrong. The fix and the new test look right to me. One thing before this merges, though: codeant's thread on the null-group-key denominator is still open. Not sure if that's actually in scope here or a pre-existing quirk unrelated to what this PR touches, but let's get it addressed (or explicitly punted) before this lands. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
