sadpandajoe opened a new pull request, #44672: URL: https://github.com/apache/superset/pull/44672
### SUMMARY Adds coverage for how a dashboard hydrates from its URL and metadata: - `?edit=true` hydrates edit mode only for users who can edit the dashboard. - Regular URL query params merge into each chart's `form_data.url_params`, overriding same-key params while keeping the chart's other params; the reserved `edit` and `standalone` params are excluded. - `filter_bar_orientation` is read from dashboard metadata, falling back to vertical. - The dashboard mount log event fires on mount with the edit/publish state. - The app navigation menu is hidden when the `standalone` URL param is set. Test-only change; no production code is modified. Each new assertion was verified to fail when the guarded production line is temporarily broken. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF N/A (tests only) ### TESTING INSTRUCTIONS ```bash cd superset-frontend npm run test -- src/dashboard/actions/hydrate.test.ts src/dashboard/components/Dashboard.test.tsx src/features/home/Menu.test.tsx ``` ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
