sadpandajoe opened a new pull request, #44671: URL: https://github.com/apache/superset/pull/44671
### SUMMARY Adds React Testing Library coverage for two dashboard header modals that had no tests: - **SaveModal**: overwrite vs. save-as payloads, the default "<title> [copy]" name, editing the name switching to save-as, `duplicate_slices`, the empty-name guard, overwrite being disabled (and save-as used) when the user cannot overwrite, and cancel. - **RefreshIntervalModal**: persisted save in edit mode vs. session-only save, the configured minimum refresh limit blocking save, and cancel restoring the original frequency. Test-only change; no production code is modified. Each new assertion was verified to fail when the guarded production line is temporarily broken. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF N/A (tests only) ### TESTING INSTRUCTIONS ```bash cd superset-frontend npm run test -- src/dashboard/components/SaveModal.test.tsx src/dashboard/components/RefreshIntervalModal.test.tsx ``` ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
