sadpandajoe opened a new pull request, #44675:
URL: https://github.com/apache/superset/pull/44675

   ### SUMMARY
   Adds coverage for the native filter bar runtime:
   
   - The filter state key API helpers send the expected create, update, and 
read requests, parse stored values, and resolve to null when a request fails.
   - The filter bar creates a new filter state key and writes it to the URL 
when none exists, and on Apply updates the key already in the URL with the 
applied values instead of creating another one.
   - The filter bar state hooks keep native filter, chart customization, and 
legacy entries in the applied data mask, drop selections that no longer map to 
a known filter, and report readiness once required filters or loading charts 
allow it (including the no-charts fallback).
   
   Test-only change; no production code is modified. Each new assertion was 
verified to fail when the guarded production line is temporarily broken.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   N/A (tests only)
   
   ### TESTING INSTRUCTIONS
   ```bash
   cd superset-frontend
   npm run test -- 
src/dashboard/components/nativeFilters/FilterBar/FilterBar.test.tsx 
src/dashboard/components/nativeFilters/FilterBar/keyValue.test.ts 
src/dashboard/components/nativeFilters/FilterBar/state.test.ts
   ```
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to