sadpandajoe opened a new pull request, #44677:
URL: https://github.com/apache/superset/pull/44677

   ### SUMMARY
   Adds unit tests for the dashboard color scheme utilities 
(`src/utils/colorScheme.ts`):
   
   - Shared and fresh label color map entries, including exclusion of labels 
that have a custom label color.
   - Scheme domain lookup: the registered scheme's colors, fallback to the 
default scheme for an unknown scheme, and an empty domain when no scheme is 
registered.
   - Labels color map sync detection that ignores drift on custom labels but 
detects it elsewhere.
   - `resetColors` clearing both the forced namespace colors and the labels 
color map.
   - `refreshLabelsColorMap` letting a dashboard-level scheme take precedence 
over a chart's own scheme, and falling back to the chart's scheme when the 
dashboard has none.
   
   Test-only change; no production code is modified. Each new assertion was 
verified to fail when the guarded production line is temporarily broken.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   N/A (tests only)
   
   ### TESTING INSTRUCTIONS
   ```bash
   cd superset-frontend
   npm run test -- src/utils/colorScheme.test.ts
   ```
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to