bito-code-review[bot] commented on PR #44628:
URL: https://github.com/apache/superset/pull/44628#issuecomment-5841180227
<!-- Bito Reply -->
The flagged issue is correct. When temporal x-axis values are provided as
ISO strings or `Date` objects, `getXAxisDomain` fails to identify numeric
bounds, causing the bar width to default to the 100-pixel cap. To resolve this,
you should update `getXAxisDomain` to handle temporal data types by calculating
the domain based on the time range or by ensuring the axis type is correctly
recognized as temporal, allowing ECharts to handle the bar width dynamically.
**superset-frontend/plugins/plugin-chart-echarts/src/utils/series.ts**
```
export function getXAxisDomain(
data: any[],
xAxisType: AxisType,
// ...
) {
if (xAxisType === AxisType.Time) {
return [min(data, d => d.x), max(data, d => d.x)];
}
// ... existing numeric logic
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
