codeant-ai-for-open-source[bot] commented on code in PR #44628:
URL: https://github.com/apache/superset/pull/44628#discussion_r4109409661
##########
superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/transformProps.ts:
##########
@@ -282,7 +284,43 @@ export default function transformProps(
getMetricDisplayName(metricsB[0], verboseMap) || '';
const dataTypes = getColtypesMapping(queriesData[0]);
- const xAxisDataType = dataTypes?.[xAxisLabel] ?? dataTypes?.[xAxisOrig];
+ const rawXAxisDataType = dataTypes?.[xAxisLabel] ?? dataTypes?.[xAxisOrig];
Review Comment:
**Suggestion:** `rawXAxisDataType` is read only from query A, so a malformed
query-A coltype ignores a valid temporal coltype supplied by query B for the
shared axis.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Rarely` ยท ๐ท๏ธ `Api mismatch`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=08b44871673d48fa9fe79798f4ac0f02&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=08b44871673d48fa9fe79798f4ac0f02&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/transformProps.ts
**Line:** 287:287
**Comment:**
*Api Mismatch: `rawXAxisDataType` is read only from query A, so a
malformed query-A coltype ignores a valid temporal coltype supplied by query B
for the shared axis.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44628&comment_hash=9ed75a95f7c18e49e0731d9a8289f31b6a7f246e1e2a19a809c1f61162d574c1&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44628&comment_hash=9ed75a95f7c18e49e0731d9a8289f31b6a7f246e1e2a19a809c1f61162d574c1&reaction=dislike'>๐</a>
##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts:
##########
@@ -1514,6 +1565,38 @@ export default function transformProps(
}
}
+ // Size a bar series to its own grain-bucket pixel width instead of a flat
+ // constant, so a sparse bucket doesn't visually spill into neighboring,
+ // unpopulated buckets. Computed here โ after `padding` is fully finalized
+ // (legend layout, compact-chart clamping, rotated-label extra padding,
+ // and the horizontal-orientation swap above have all already run) and
+ // applied as a post-pass over the already-built `renderedSeries` โ so the
+ // plot-length used matches the *actual* grid area ECharts will render
+ // into, not a flat per-side constant: a heavily-padded chart (e.g. a
+ // side legend eating a large share of a narrow chart) genuinely has far
+ // less plot area than `width`/`height` alone would suggest. Only
+ // meaningful when a bar series is actually rendered โ skip the domain
+ // scan otherwise. See getGrainBarMaxWidth for the domain/grain part of
+ // the mechanism.
+ if (seriesType === EchartsTimeseriesSeriesType.Bar) {
+ const barMaxWidthPx = getGrainBarMaxWidth(
+ xAxisType,
+ resolvedTimeGrain,
+ [rebasedData as Record<string, unknown>[]],
+ xAxisLabel,
+ isHorizontal
+ ? Math.max(height - padding.top - padding.bottom, 0)
+ : Math.max(width - padding.left - padding.right, 0),
+ );
Review Comment:
**Suggestion:** `getGrainBarMaxWidth` only recognizes numeric x-values, so
Date or ISO-string temporal rows return no cap and retain the old 100px
sparse-bar behavior.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Rarely` ยท ๐ท๏ธ `Type error`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=3e2258b33ae24175b9d0a80c9d0a7f87&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=3e2258b33ae24175b9d0a80c9d0a7f87&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts
**Line:** 1582:1590
**Comment:**
*Type Error: `getGrainBarMaxWidth` only recognizes numeric x-values, so
Date or ISO-string temporal rows return no cap and retain the old 100px
sparse-bar behavior.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44628&comment_hash=fcd4bd42792de5db4393c592868d0c828fcaf048de950b0bf596ccf7c4b95ee7&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44628&comment_hash=fcd4bd42792de5db4393c592868d0c828fcaf048de950b0bf596ccf7c4b95ee7&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
