codeant-ai-for-open-source[bot] commented on code in PR #44720:
URL: https://github.com/apache/superset/pull/44720#discussion_r4113633040
##########
superset/db_engine_specs/crate.py:
##########
@@ -88,5 +88,9 @@ def convert_dttm(
@classmethod
def alter_new_orm_column(cls, orm_col: TableColumn) -> None:
- if orm_col.type == "TIMESTAMP":
+ if orm_col.type in {
+ "TIMESTAMP",
+ "TIMESTAMP WITHOUT TIME ZONE",
+ "TIMESTAMP WITH TIME ZONE",
+ }:
orm_col.python_date_format = "epoch_ms"
Review Comment:
✅ **CodeAnt verified this suggestion was addressed in subsequent commits and
marked this thread resolved** as of `ab6deb1`.
Added `fetch_data` handling for Crate timestamp result type codes that
converts numeric epoch-millisecond values to UTC-naive datetimes, preventing
them from being interpreted as nanoseconds even for existing columns.
<sub>If that's not right, unresolve this thread and CodeAnt will leave it
open.</sub>
<!-- codeant-auto-resolve-reply -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
