aminghadersohi commented on code in PR #44720:
URL: https://github.com/apache/superset/pull/44720#discussion_r4113666671
##########
superset/db_engine_specs/crate.py:
##########
@@ -88,5 +88,9 @@ def convert_dttm(
@classmethod
def alter_new_orm_column(cls, orm_col: TableColumn) -> None:
- if orm_col.type == "TIMESTAMP":
+ if orm_col.type in {
+ "TIMESTAMP",
+ "TIMESTAMP WITHOUT TIME ZONE",
+ "TIMESTAMP WITH TIME ZONE",
+ }:
orm_col.python_date_format = "epoch_ms"
Review Comment:
Fixed in ab6deb1: fetch_data converts typed timestamp results to UTC-naive
datetimes independently of the stored format. Verified on four datasets created
with the old code: their saved charts are correct without metadata edits; three
were never refreshed. All 19 unit tests pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
