bito-code-review[bot] commented on code in PR #44627:
URL: https://github.com/apache/superset/pull/44627#discussion_r4113885099
##########
docs/src/components/databases/DatabasePage.tsx:
##########
@@ -492,6 +492,30 @@ const DatabasePage: React.FC<DatabasePageProps> = ({
database, name }) => {
);
};
+ // Render extended aggregate function support (MEDIAN/STDDEV_SAMP/VAR_SAMP)
+ const renderExtendedAggregations = () => {
+ const aggregations = database.extended_aggregations;
+ if (!aggregations || Object.keys(aggregations).length === 0) return null;
+
+ return (
+ <Card title="Extended Aggregate Functions" style={{ marginBottom: 16 }}>
+ <Text type="secondary" style={{ display: 'block', marginBottom: 8 }}>
+ The base aggregates (SUM, COUNT, AVG, MIN, MAX, COUNT DISTINCT) are
+ supported everywhere; these are opt-in per engine.
Review Comment:
<!-- Bito Reply -->
The reviewer's suggestion to introduce i18n is consistent with best
practices for user-facing strings, even if the current site lacks full i18n
wiring. Applying this change now establishes a standard for future components
and avoids accumulating hardcoded strings that would require refactoring later.
It is recommended to proceed with the suggestion to ensure long-term
maintainability.
**docs/src/components/databases/DatabasePage.tsx**
```
// Render extended aggregate function support (MEDIAN/STDDEV_SAMP/VAR_SAMP)
const renderExtendedAggregations = () => {
const aggregations = database.extended_aggregations;
if (!aggregations || Object.keys(aggregations).length === 0) return null;
return (
<Card title="Extended Aggregate Functions" style={{ marginBottom: 16
}}>
<Text type="secondary" style={{ display: 'block', marginBottom: 8 }}>
The base aggregates (SUM, COUNT, AVG, MIN, MAX, COUNT DISTINCT) are
supported everywhere; these are opt-in per engine.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
