rusackas commented on code in PR #44627:
URL: https://github.com/apache/superset/pull/44627#discussion_r4113884006
##########
docs/src/components/databases/DatabasePage.tsx:
##########
@@ -492,6 +492,30 @@ const DatabasePage: React.FC<DatabasePageProps> = ({
database, name }) => {
);
};
+ // Render extended aggregate function support (MEDIAN/STDDEV_SAMP/VAR_SAMP)
+ const renderExtendedAggregations = () => {
+ const aggregations = database.extended_aggregations;
+ if (!aggregations || Object.keys(aggregations).length === 0) return null;
Review Comment:
Fixed, `_extended_aggregations` is a class-level annotated assignment, and
the AST fallback's parsing only handled plain `Assign`, so it skipped the dict
entirely. Added key extraction plus an inheritance-aware resolver, and patched
the Databricks/Snowflake entries in `databases.json` directly.
##########
docs/src/components/databases/DatabasePage.tsx:
##########
@@ -492,6 +492,30 @@ const DatabasePage: React.FC<DatabasePageProps> = ({
database, name }) => {
);
};
+ // Render extended aggregate function support (MEDIAN/STDDEV_SAMP/VAR_SAMP)
+ const renderExtendedAggregations = () => {
+ const aggregations = database.extended_aggregations;
Review Comment:
Same root cause: `_extended_aggregations` is an annotated assignment, and
the AST fallback only parsed plain `Assign`. Added key extraction with an
inheritance-aware resolver, and patched the Databricks/Snowflake entries in
`databases.json` directly so they don't have to wait on a regen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
