aminghadersohi commented on PR #44148: URL: https://github.com/apache/superset/pull/44148#issuecomment-5866324491
@sha174n thanks for the careful pass. On the `Literal` point, I'm keeping both fields as bounded free text: - `linear_color_scheme`: the sequential scheme registry is open. Operators add schemes through `EXTRA_SEQUENTIAL_COLOR_SCHEMES`, which reaches the frontend through bootstrap data, and the ~55 built-in ids exist only in the frontend. A `Literal` would reject valid custom schemes on those deployments and would copy a list that goes stale as soon as the frontend changes. - `number_format`: this is a d3-format string (`,.2f`, `$,.0f`, `SMART_NUMBER`, …), so there's no fixed set to enumerate. It also matches how `number_format` is typed on every other chart config in this schema. Agreed that `sql_expression` deserves its own conversation, separate from this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
