EnxDev commented on code in PR #43938:
URL: https://github.com/apache/superset/pull/43938#discussion_r4121855400


##########
superset/translations/messages.pot:
##########
@@ -37,39 +37,28 @@ msgstr ""
 #, python-format
 msgid ""
 "\n"
-"                <p>Your report/alert was unable to be generated because "
-"of the following error: %(text)s</p>\n"
+"                <p>Your report/alert was unable to be generated because of 
the following error: %(text)s</p>\n"

Review Comment:
   This line is one example: every long msgid in the pot got unwrapped onto one 
line, which is where the -1921 lines come from. Master keeps them wrapped, so 
any other open PR that touches the pot will now conflict all over the file, and 
the next regeneration on master will probably wrap them back.
   
   Could you restore master's pot and add just the new msgids in sorted 
position? `scripts/translations/check_pot_drift.py` will confirm the set still 
matches. The .po files and the do-not-translate markers look fine.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to