SBIN2010 commented on code in PR #43938:
URL: https://github.com/apache/superset/pull/43938#discussion_r4148167496
##########
superset-frontend/plugins/plugin-chart-ag-grid-table/src/controlPanel.tsx:
##########
@@ -63,12 +65,8 @@ import { PAGE_SIZE_OPTIONS, SERVER_PAGE_SIZE_OPTIONS } from
'./consts';
/**
* Generate comparison column names for a given column.
*/
-const generateComparisonColumns = (colname: string) => [
- `${t('Main')} ${colname}`,
- `# ${colname}`,
- `△ ${colname}`,
- `% ${colname}`,
-];
+const generateComparisonColumns = (colname: string) =>
+ getTimeComparisonColumnKeys(colname);
Review Comment:
fix in e7580433be — Old keys like "Principale revenue" are rewritten to
"Main revenue" before the `column_config` filter so that the column
configuration is not lost.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
