rusackas commented on code in PR #44738:
URL: https://github.com/apache/superset/pull/44738#discussion_r4119198154
##########
.github/workflows/pre-commit.yml:
##########
@@ -137,20 +116,93 @@ jobs:
if [ "$(printf '%s' "${files}" | wc -c)" -gt 100000 ]; then
echo "::notice::Changed-file list too large to pass via env;
falling back to --all-files."
echo "mode=all" >> "$GITHUB_OUTPUT"
+ emit_needs all
exit 0
fi
if [ -z "${files}" ]; then
echo "mode=none" >> "$GITHUB_OUTPUT"
+ emit_needs none
else
echo "mode=files" >> "$GITHUB_OUTPUT"
{
echo "files<<__CHANGED_FILES_EOF__"
echo "${files}"
echo "__CHANGED_FILES_EOF__"
} >> "$GITHUB_OUTPUT"
+ if printf '%s\n' "${files}" | grep -q '^superset-frontend/'; then
Review Comment:
Good catch, real bug. Fixed in 44fe918, by moving this out of bash entirely
into `scripts/pre_commit_dependency_needs.py` (with tests) rather than just
swapping in a here-string, since a pipe wasn't the only way to trip this. Same
convention this repo already uses for the main CI workflow's own
change-detection gate (`scripts/change_detector.py`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
