codeant-ai-for-open-source[bot] commented on code in PR #44738:
URL: https://github.com/apache/superset/pull/44738#discussion_r4119196957
##########
.github/workflows/pre-commit.yml:
##########
@@ -137,20 +116,93 @@ jobs:
if [ "$(printf '%s' "${files}" | wc -c)" -gt 100000 ]; then
echo "::notice::Changed-file list too large to pass via env;
falling back to --all-files."
echo "mode=all" >> "$GITHUB_OUTPUT"
+ emit_needs all
exit 0
fi
if [ -z "${files}" ]; then
echo "mode=none" >> "$GITHUB_OUTPUT"
+ emit_needs none
else
echo "mode=files" >> "$GITHUB_OUTPUT"
{
echo "files<<__CHANGED_FILES_EOF__"
echo "${files}"
echo "__CHANGED_FILES_EOF__"
} >> "$GITHUB_OUTPUT"
+ if printf '%s\n' "${files}" | grep -q '^superset-frontend/'; then
Review Comment:
✅ **CodeAnt verified this suggestion was addressed in subsequent commits and
marked this thread resolved** as of `44fe918`.
Replaced the inline `printf | grep -q` pipeline with `printf '%s\n'
"${{files}}" | python3 scripts/pre_commit_dependency_needs.py`, which reads
stdin through EOF and avoids early pipe closure under `pipefail`.
<sub>If that's not right, unresolve this thread and CodeAnt will leave it
open.</sub>
<!-- codeant-auto-resolve-reply -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
