aminghadersohi commented on PR #43770: URL: https://github.com/apache/superset/pull/43770#issuecomment-5883091053
@rusackas thanks, both addressed in d040008011. For the lookup split, update_chart and update_chart_preview now enter a registry `saved_chart_contract()` scope for the saved (or cached) chart, so the strict rebind guard, `resolve_update_config`, normalization and mapping resolve the same plugin `plugin_for_viz_type()` does even when that type is disabled; other disabled types stay unreachable, so an update still can't switch a chart to one. Previously these updates failed outright in mapping, which the new disabled-Treemap tests reproduced. Gantt's `allows_empty_result` came in with this PR's plugin-contract refactor and isn't on master, so I dropped it: a zero-row Gantt query returns NoData again, with saved and unsaved tests for it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
