aminghadersohi commented on code in PR #43770:
URL: https://github.com/apache/superset/pull/43770#discussion_r4129947280
##########
superset/mcp_service/chart/tool/update_chart.py:
##########
@@ -72,6 +78,13 @@
logger = logging.getLogger(__name__)
+def _bounded_update_response(payload: object) -> GenerateChartResponse:
Review Comment:
Fixed in 70611d12b4f566cd690093318d5159cf28caa57c: forwarded the persisted
chart ID to response preflight after a saved update, with update-specific
confirmation and retry guidance. The oversized-response regression verifies
that the saved chart ID remains available.
##########
superset/mcp_service/chart/tool/generate_chart.py:
##########
@@ -85,6 +98,10 @@ async def generate_chart( # noqa: C901
- Set save_chart=True to permanently save the chart
- LLM clients MUST display returned chart URL to users
- Use numeric dataset ID or UUID (NOT schema.table_name format)
+ - MUST include chart_type in config (one of: 'xy', 'table', 'pie',
'bullet',
Review Comment:
Fixed in 70611d12b4f566cd690093318d5159cf28caa57c: removed the duplicate
discriminator list and added bullet to the existing correct list, retaining
gauge, treemap_v2, bubble_v2, and gantt.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
