rusackas commented on PR #44665: URL: https://github.com/apache/superset/pull/44665#issuecomment-5883176305
@kokhlo good regression coverage, but there's a real gap: `getValueRange` only coerces numeric strings when `hasCellBarFormatter` is true (TableChart.tsx:1090), while the render path parses every cell unconditionally via `parseNumeric` (line 1131). With just the global `Show cell bars` toggle on (no `CELL_BAR` rule) and a column mixing numbers with numeric strings - the exact DECIMAL-as-string case this PR is about - bars now render for the string cells against a range that excluded them, so width/offset can land outside the cell. codeant and bito both flagged this same spot independently. Can you pass `generalShowCellBars || hasCellBarFormatter` into `getValueRange` so range and render agree? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
