Copilot commented on code in PR #44665:
URL: https://github.com/apache/superset/pull/44665#discussion_r4138151564
##########
superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx:
##########
@@ -1050,11 +1084,29 @@ export default function TableChart<D extends DataRecord
= DataRecord>(
basicColorFormatters.length > 0;
const generalShowCellBars =
config.showCellBars === undefined ? showCellBars : config.showCellBars;
+ // A Cell bar conditional-formatting rule must keep working even when the
+ // generic "Show cell bars" toggle is off: the toggle controls the
default
+ // gradient, not whether an explicit formatter rule can draw its bar.
Review Comment:
This new behavior contradicts the existing user-facing CELL_BAR tooltip in
`FormattingPopoverContent.tsx:737-740`, which still says bars are displayed
only when “Show cell bars” is enabled. Update that tooltip so Explore no longer
gives users the opposite instruction.
This issue also appears on line 1270 of the same file.
##########
superset-frontend/plugins/plugin-chart-table/test/TableChart.test.tsx:
##########
@@ -50,6 +50,71 @@ import transformProps from '../src/transformProps';
import testData from './testData';
import { ProviderWrapper } from './testHelpers';
+// The bar's width comes from an emotion class, not an inline style, so it has
+// to be read back out of the stylesheet the rule actually generated.
Review Comment:
This comment describes the old Emotion-class implementation, but the
production change now puts width in an inline `style`. Keep the helper
documentation aligned with what it is actually validating.
This issue also appears on line 1238 of the same file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
