sadpandajoe commented on code in PR #43712:
URL: https://github.com/apache/superset/pull/43712#discussion_r4129498022
##########
docs/src/data/databases.json:
##########
@@ -1742,87 +1739,6 @@
"supports_catalog": false,
"supports_dynamic_catalog": false
},
- "Ascend": {
- "time_grains": {
- "SECOND": true,
- "FIVE_SECONDS": false,
- "THIRTY_SECONDS": false,
- "MINUTE": true,
- "FIVE_MINUTES": false,
- "TEN_MINUTES": false,
- "FIFTEEN_MINUTES": false,
- "THIRTY_MINUTES": false,
- "HALF_HOUR": false,
- "HOUR": true,
- "SIX_HOURS": false,
- "DAY": true,
- "WEEK": true,
- "WEEK_STARTING_SUNDAY": false,
- "WEEK_STARTING_MONDAY": false,
- "WEEK_ENDING_SATURDAY": false,
- "WEEK_ENDING_SUNDAY": false,
- "MONTH": true,
- "QUARTER": true,
- "QUARTER_YEAR": false,
- "YEAR": true
- },
- "module": "superset.db_engine_specs.ascend",
- "limit_method": 1,
- "limit_clause": true,
- "joins": true,
- "subqueries": true,
- "alias_in_select": true,
- "alias_in_orderby": true,
- "time_groupby_inline": false,
- "alias_to_source_column": false,
- "order_by_not_in_select": true,
- "expressions_in_orderby": false,
- "cte_in_subquery": true,
- "max_column_name": null,
- "sql_comments": true,
- "escaped_colons": true,
- "masked_encrypted_extra": false,
- "column_type_mapping": false,
- "function_names": false,
- "user_impersonation": false,
- "file_upload": true,
- "get_extra_table_metadata": false,
- "dbapi_exception_mapping": false,
- "custom_errors": false,
- "dynamic_schema": false,
- "catalog": false,
- "dynamic_catalog": false,
- "ssh_tunneling": true,
- "query_cancelation": true,
- "get_metrics": false,
- "where_latest_partition": false,
- "expand_data": false,
- "query_cost_estimation": false,
- "sql_validation": false,
- "score": 38,
- "max_score": 201,
- "documentation": {
- "description": "Ascend.io is a data automation platform for building
data pipelines.",
- "logo": "ascend.webp",
- "homepage_url": "https://www.ascend.io/";,
- "categories": [
- "Cloud Data Warehouses",
- "Analytical Databases",
- "Hosted Open Source"
- ],
- "pypi_packages": ["impyla"],
- "connection_string":
"ascend://{username}:{password}@{hostname}:{port}/{database}?auth_mechanism=PLAIN;use_ssl=true",
- "category": "Other Databases"
- },
- "engine": "ascend",
- "engine_name": "Ascend",
- "engine_aliases": [],
- "default_driver": null,
- "supports_file_upload": true,
- "supports_dynamic_schema": false,
- "supports_catalog": false,
- "supports_dynamic_catalog": false
- },
"Aurora MySQL": {
Review Comment:
Removing the Ascend entry didn't update this file's generated `statistics`
block (lines 4-10): `totalDatabases`, `withDocumentation`, and
`withConnectionString` still read 81 instead of 80, and
`supportsJoins`/`supportsSubqueries` still read 75/78 instead of 74/77.
Anything reading these counts (including the docs page they back) now reports
numbers that don't match the actual entries. Could this be regenerated as part
of the removal?
##########
superset/db_engine_specs/README.md:
##########
@@ -101,7 +101,6 @@ The tables below (generated via `python
superset/db_engine_specs/lib.py`) summar
| SQLite | 41 | Supported | Partial | Supported | Supported | Not supported |
Not supported |
| Shillelagh | 41 | Supported | Partial | Supported | Supported | Not
supported | Not supported |
| KustoKQL | 40 | Supported | Partial | Partial | Partial | Partial | Not
supported |
-| Ascend | 38 | Supported | Partial | Supported | Not supported | Partial |
Not supported |
| DuckDB | 38 | Supported | Partial | Supported | Not supported | Partial |
Not supported |
Review Comment:
Removing Ascend's engine spec - including its `registry.register("ascend",
"impala.sqlalchemy", "ImpalaDialect")` call in the now-deleted
`superset/db_engine_specs/ascend.py` - means
`Database.driver`/`Database.backend` now raise
`sqlalchemy.exc.NoSuchModuleError` for any already-persisted `ascend://`
connection. `GET /api/v1/database/{pk}/connection` in
`superset/databases/api.py` serializes those fields via
`DatabaseConnectionSchema` before its local exception handler, so the call
escapes to the route's generic error wrapper and returns a plain 500 instead of
the connection data. The edit modal depends on this endpoint to load, so an
operator can no longer open the edit UI for an existing Ascend connection to
make the `ascend://` -> `impala://` change this PR's own `UPDATING.md` entry
recommends. Could the endpoint handle this so the documented migration path
still works?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
