rusackas commented on PR #43232: URL: https://github.com/apache/superset/pull/43232#issuecomment-5883410259
Heya @MallikarjunaReddyN, thanks for adding the `can_write` check and getting this rebased, appreciate it. One thing though: that check calls `security_manager.can_access` outside a request context, so `g.user` isn't set when the import command runs directly. That's throwing `AttributeError: user` and failing six tests across `test-postgres`, `test-mysql`, and `test-sqlite` right now. EnxDev's other note, about the A/B circular reference still dropping one side's annotation, looks open too. Let's get both cleared before this goes back to review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
