bito-code-review[bot] commented on code in PR #44342:
URL: https://github.com/apache/superset/pull/44342#discussion_r4131548522
##########
superset/translations/messages.pot:
##########
@@ -321,10 +359,34 @@ msgstr ""
msgid "%s Virtual"
msgstr ""
+#, python-format
+msgid "%s additional restricted chart"
+msgid_plural "%s additional restricted charts"
+msgstr[0] ""
+msgstr[1] ""
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Dead plural msgid chart</b></div>
<div id="fix">
This plural msgid has no source: the only consumer,
`ArchivedDatasetPurgeModal.tsx:118`, calls `t('%(count)s additional restricted
%(label)s')` (that variant is also added at lines 204-210), never `tn()`. Babel
cannot have extracted this form from the current tree, so it is a dead catalog
entry translators may waste effort on. Remove it or migrate the modal to `tn()`.
</div>
</div>
<small><i>Code Review Run #a07ad6</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/messages.pot:
##########
@@ -321,10 +359,34 @@ msgstr ""
msgid "%s Virtual"
msgstr ""
+#, python-format
+msgid "%s additional restricted chart"
+msgid_plural "%s additional restricted charts"
+msgstr[0] ""
+msgstr[1] ""
+
+#, python-format
+msgid "%s additional restricted dashboard"
+msgid_plural "%s additional restricted dashboards"
+msgstr[0] ""
+msgstr[1] ""
+
+#, python-format
+msgid "%s affected chart"
+msgid_plural "%s affected charts"
+msgstr[0] ""
+msgstr[1] ""
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Stale template entry</b></div>
<div id="fix">
No `t()`/`tn()` call in the repo produces `%s affected chart(s)` — repo-wide
search over py/ts/tsx/jsx finds only test names and a migration docstring,
while the delete-modals emit different strings (e.g. `Checking for affected
charts and dashboards…`). The entry can never be matched at lookup time; drop
it or restore its source string.
</div>
</div>
<small><i>Code Review Run #a07ad6</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/messages.pot:
##########
@@ -321,10 +359,34 @@ msgstr ""
msgid "%s Virtual"
msgstr ""
+#, python-format
+msgid "%s additional restricted chart"
+msgid_plural "%s additional restricted charts"
+msgstr[0] ""
+msgstr[1] ""
+
+#, python-format
+msgid "%s additional restricted dashboard"
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Dead plural msgid dashboard</b></div>
<div id="fix">
Same dead-entry defect as the chart twin at lines 362-366: no source
produces `%s additional restricted dashboard`;
`ArchivedDatasetPurgeModal.tsx:118` uses `t('%(count)s additional restricted
%(label)s')`. Remove this entry or adopt `tn()` in the modal so the plural
forms become live.
</div>
</div>
<small><i>Code Review Run #a07ad6</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/messages.pot:
##########
@@ -785,9 +921,23 @@ msgid ""
"https://echarts.apache.org/en/option.html. "
msgstr ""
+msgid "A Slack channel is required for Slack recipients"
+msgstr ""
+
msgid "A TTL is required for ephemeral state."
msgstr ""
+msgid ""
+"A butterfly chart compares two metrics across categories using horizontal"
+" bars that extend left and right from a central axis."
+msgstr ""
+
+msgid ""
+"A candlestick chart shows opening, closing, high, and low values for each"
+" period. It is commonly used for financial and other time-series range "
+"analysis."
+msgstr ""
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Entry for absent feature</b></div>
<div id="fix">
`candlestick` appears nowhere in the repo outside this template — no plugin,
component, or chart type emits this description (the sibling butterfly
description does, in `plugin-chart-echarts/src/Butterfly/index.ts`). The entry
is unreachable at lookup and describes a feature that does not exist here;
remove it until the chart ships.
</div>
</div>
<small><i>Code Review Run #a07ad6</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/messages.pot:
##########
@@ -117,8 +126,8 @@ msgid ""
"Note\n"
" currently time zones are not supported. If time is "
"stored\n"
-" in epoch format, put `epoch_s` or `epoch_ms`. If no"
-" pattern\n"
+" in epoch format, put `epoch_s`, `epoch_ms` or "
+"`epoch_us`. If no pattern\n"
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>POT msgid mismatch epoch_us</b></div>
<div id="fix">
The regenerated msgid now advertises `epoch_us`, but nothing in the tree
produces or supports it: `DatasourceEditor.tsx:685` still reads `epoch_s` or
`epoch_ms`, and `db_engine_specs/base.py:1256` handles only
`epoch_s`/`epoch_ms`. gettext matches by exact msgid, so after .po sync the
real tooltip loses its catalog entry and non-English users see the untranslated
English text. Revert the msgid or land the `epoch_us` support it presupposes.
</div>
</div>
<small><i>Code Review Run #a07ad6</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/messages.pot:
##########
@@ -2063,13 +2294,18 @@ msgstr ""
msgid "Archived by"
msgstr ""
-msgid "Archived within"
+msgid "Archived items must be recovered before they can be opened."
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Stale POT entry swap</b></div>
<div id="fix">
The extraction dropped `msgid "Archived within"` while
`BaseDeletedRecencyFilter.name` (superset/views/filters.py:330) still calls
`lazy_gettext` with it, so that filter label loses translation coverage; its
replacement entry "Archived items must be recovered..." has no occurrence in
the source tree. Restore the in-use entry and remove the orphan - re-running
the POT extraction reconciles both.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
````suggestion
msgid "Archived within"
msgstr ""
````
</div>
</details>
</div>
<small><i>Code Review Run #a07ad6</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/messages.pot:
##########
@@ -785,9 +921,23 @@ msgid ""
"https://echarts.apache.org/en/option.html. "
msgstr ""
+msgid "A Slack channel is required for Slack recipients"
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Unmatched msgid</b></div>
<div id="fix">
No source file contains `A Slack channel is required for Slack recipients` —
case-insensitive repo-wide search over py/ts/tsx finds nothing outside this
template. Report-recipient validation never emits it, so the entry is
unreachable at lookup; remove it or add the emitting source string.
</div>
</div>
<small><i>Code Review Run #a07ad6</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
