bito-code-review[bot] commented on code in PR #44342: URL: https://github.com/apache/superset/pull/44342#discussion_r4148055604
########## superset/translations/messages.pot: ########## @@ -165,7 +165,7 @@ msgstr "" msgid "\"%s\" is now the system default theme" msgstr "" -#, no-python-format +#, python-format Review Comment: <div> <div id="suggestion"> <div id="issue"><b>python-format flag regression</b></div> <div id="fix"> scripts/translations/babel_update.sh (lines 95-122) strips python-format and forces no-python-format for exactly msgid "% calculation", documenting that babel auto-flags it on every write and msgfmt then fatals on translations containing a bare '%'. Re-adding python-format makes the committed template diverge from the canonical workflow output. Restore '#, no-python-format'. </div> </div> <small><i>Code Review Run #30f82b</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/messages.pot: ########## @@ -185,15 +185,15 @@ msgstr "" msgid "% of grand total" msgstr "" -#, no-python-format +#, python-format Review Comment: <div> <div id="suggestion"> <div id="issue"><b>python-format flag regression</b></div> <div id="fix"> Same regression as the sibling entries: scripts/translations/babel_update.sh:95-122 strips python-format and forces no-python-format for exactly msgid "% of parent", because babel auto-flags it and msgfmt fatals on translations containing a bare '%' (30 PO catalogs counted with such msgstr values). Restore '#, no-python-format' so the template matches canonical workflow output. </div> </div> <small><i>Code Review Run #30f82b</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/messages.pot: ########## @@ -185,15 +185,15 @@ msgstr "" msgid "% of grand total" msgstr "" -#, no-python-format +#, python-format msgid "% of parent" msgstr "" #, python-format msgid "% of row total" msgstr "" -#, no-python-format +#, python-format Review Comment: <div> <div id="suggestion"> <div id="issue"><b>python-format flag regression</b></div> <div id="fix"> Same regression: scripts/translations/babel_update.sh:95-122 strips python-format and forces no-python-format for exactly msgid "% of total", documenting that msgfmt fatals on its bare-'%' translations (e.g. de '% von Gesamtsumme', cs '% z celku'; 30 catalogs counted). The flip makes the committed template diverge from canonical output. Restore '#, no-python-format'. </div> </div> <small><i>Code Review Run #30f82b</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
