rusackas commented on code in PR #43917:
URL: https://github.com/apache/superset/pull/43917#discussion_r4131756999
##########
superset-frontend/plugins/plugin-chart-pivot-table/src/react-pivottable/TableRenderers.tsx:
##########
@@ -1154,7 +1174,16 @@ export function TableRenderer(props: TableRendererProps)
{
i + 1 < maxRowVisible! ? arrowExpanded : arrowCollapsed;
}
return (
- <th className="pvtAxisLabel" key={`rowAttr-${i}`}>
+ <th
+ className="pvtAxisLabel"
+ key={`rowAttr-${i}`}
+ colSpan={isLastRowAttr && mergeTotalLabel ? 2 : undefined}
Review Comment:
Intentional — that cell absorbs the old blank `pvtTotalLabel` spacer when
merged, so its click contract comes along with it. `clickRowHeaderCallback`
ignores grand totals so nothing changes for the built-in case, but yeah, a
custom callback would now see a click on the label text reported as a
grand-total click.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
