sadpandajoe commented on code in PR #43917:
URL: https://github.com/apache/superset/pull/43917#discussion_r4140846522
##########
superset-frontend/plugins/plugin-chart-pivot-table/src/react-pivottable/Styles.ts:
##########
@@ -63,6 +100,19 @@ export const Styles = styled.div<{ isDashboardEditMode:
boolean }>`
background-color: ${theme.colorBgBase};
}
+ /* The totals row's leading label freezes at the left edge like the
+ * body row labels above it. The z-index keeps it over the totals
+ * values scrolling underneath within the row's own stacking context.
+ * Scoped to the single-row-dimension case for the same reason as the
+ * corner cells above. */
+ table.pvtTable tbody tr.pvtRowTotals th.pvtRowTotalLabel {
+ position: ${
+ isDashboardEditMode || !canFreezeRowLabels ? 'inherit' : 'sticky'
Review Comment:
With multiple row dimensions, `inherit` takes the sticky position from
`.pvtRowTotals`, so this totals label still remains pinned at `left: 0` while
the other row labels scroll normally. Should this branch use a non-sticky
position instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
